Disambiguate the reference to remquo on Windows #85609
Conversation
|
@swift-ci please test |
For swiftlang#85606 This is to fix an overload ambiguity error that occur because the C/C++ types double and long double are typealias to each other in Swift on Windows and the system C++ header cmath.h defines a remquo function overload for long double which conflicts with the one in the C header corecrt_math.h in Swift.
|
@swift-ci please test |
| @@ -295,7 +295,11 @@ public func lgamma(_ x: ${T}) -> (${T}, Int) { | |||
| @_transparent | |||
| public func remquo(_ x: ${T}, _ y: ${T}) -> (${T}, Int) { | |||
| var quo = Int32(0) | |||
| #if !os(Windows) | |||
There was a problem hiding this comment.
This problem should occur for any platform that doesn't differentiate long double from double right?
I think that rather than differentiating this on os(Windows), we want to use something to differentiate this based on sizeof(long double) == sizeof(double).
There was a problem hiding this comment.
Not exactly. This also requires another condition: the way the Windows headers declare it. This doesn't occur and the following reproducer test doesn't err on macos because the macos C++ header imports the C remquo into the std namespace for C++ rather than declaring another remquo for long double that would cause an overload with C remquo for long in Swift. I added text on it in the bug description here. So I think this is specific to Windows.
2 participants
For #85606
This is to fix an overload ambiguity error that occur because the
C/C++ types double and long double are typealias to each other in
Swift on Windows and the system C++ header cmath.h defines a remquo
function overload for long double which conflicts with the one in the
C header corecrt_math.h in Swift.